This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [unwind-20030108-branch] Add sentinel-frame + misc
On Fri, Jan 10, 2003 at 01:45:55AM -0500, Andrew Cagney wrote:
> with patch,
>
> >This adds sentinal-frame.[hc] and then modifies the unwind code in frame.c
> >so that it can exploit the fact that there is alway an extra frame beyond
> >the inner most frame. This has a dramatic effect on the unwind code - so
> >much simpler!
> >
> >It doesn't do things like ensure that there is always a frame or create
> >the inner most frame from the sentinel frame.
> >
> >To confuse the patch slightly, it also adjusts the id_unwind, pc_unwind
> >and register_unwind function types.
> >
> >Andrew
Yeah!
I've just got one stylistic comment:
> -struct dummy_frame
> +struct frame_unwind_cache
> {
> - struct dummy_frame *next;
> + struct frame_unwind_cache *next;
> @@ -555,8 +522,14 @@
> If the value isn't here AND a value is needed, try the next inner
> most frame. */
>
> +struct frame_unwind_cache
> +{
> + void *regs[1];
> +};
> +
I know it makes some type-checking simpler, but naming all your private types
the same thing is a real nuisance when using this lame "GDB" thing on
the code afterwards. Must we?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer