Re: [RFA] port simple gdb.threads/schedlock.c test fix to branch

[Daniel Jacobowitz <drow at mvista dot com>]

On Mon, Dec 02, 2002 at 10:20:13PM -0600, Michael Elizabeth Chastain wrote:
> I would like to port this fix from mainline to 5.3 branch:
> 
>   http://sources.redhat.com/ml/gdb-patches/2002-10/msg00454.html
> 
>   2002-10-22  Daniel Jacobowitz  <drow@mvista.com>
> 
>         * gdb.threads/schedlock.c (args): Make unsigned.
> 
> Note that this is a test program fix, not a gdb fix.
> 
> This fix improves the results from schedlock.exp, making them more
> accurate and reproducible.  Right now, I'm getting random failures
> in schedlock.exp on the branch, and it takes work to determine that
> the failures really are random and not correlated with different
> versions of gcc and binutils.
> 
> I tested this patch in my test bed with 66 different configurations
> (on the 5.3 branch) and it works fine.  And, of course, it's been
> working in mainline just fine.
> 
> I think this is obvious, but since I've been away for a while,
> I just want to check first.
> 
> Okay to apply to the 5.3 branch?

<obvious hat>

This is OK for the branch.  I think I meant to do it at the time and
dropped the ball. I should also check that the lin-lwp fix for
schedlock.exp made the branch...

Caveat: Andrew had closed the branch for 5.2.91; I don't know if he's
opened it up again yet or how strictly we're frozen.  Andrew?

> 
> Michael C
> 
> ===
> 
> 2002-12-02  Michael Chastain  <mec@shout.net>
> 
> 	From mainline:
> 	2002-10-22  Daniel Jacobowitz  <drow@mvista.com>
>         * gdb.threads/schedlock.c (args): Make unsigned.
> 
> Index: testsuite/gdb.threads/schedlock.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/schedlock.c,v
> retrieving revision 1.1
> diff -u -p -r1.1 schedlock.c
> --- testsuite/gdb.threads/schedlock.c	23 Aug 2002 20:32:02 -0000	1.1
> +++ testsuite/gdb.threads/schedlock.c	23 Oct 2002 03:21:13 -0000
> @@ -7,7 +7,7 @@ void *thread_function(void *arg); /* Poi
>  
>  #define NUM 5
>  
> -int args[NUM+1];
> +unsigned int args[NUM+1];
>  
>  int main() {
>      int res;
> 
> 
> 
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer