This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFC: Keep 5 yr. old hack for MIPS16 on disassembler code
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: Fernando Nasser <fnasser at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 22 Nov 2002 20:21:54 -0500
- Subject: Re: RFC: Keep 5 yr. old hack for MIPS16 on disassembler code
- References: <3D98C228.9070705@redhat.com>
This hack was added 5+yrs ago to fix disassembler printing for MIPS16. The instruction disassembler code itself is unaware of that -- the hack is only for the address that is printed in front of the instructions.
This horrible macro is only defined for these MIPS16 machines, it is not a general architecture macro (which would be transformed into a multiarch function), so the ifdef.
I have filled the bug gdb/773 asking for these macros to be replaced by something cleaner. But I don't know enough about mips16 to do anything about it and if I leave this out of the code I will break that target. So I will have to add it to the new disassembler code in disasm.c (this hack was on the old code on printcmd.c) -- see attached patch.
I will check it in soon (unless someone fixes 773 first).
The macro has gone.
Andrew