This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/rfc] Deprecate DO_REGISTERS_INFO
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 23 Oct 2002 20:35:41 -0400
- Subject: Re: [patch/rfc] Deprecate DO_REGISTERS_INFO
- References: <3DB72847.9020500@redhat.com>
Andrew Cagney writes:
> Just mechanical, stop people accidently adding new targets that use it.
> (This does interact with the other patches I've posted mind, I'll need
> to do some careful ordering.)
>
> I'll commit this one first, tomorrow, even though I posted it last :-).
Looks good for sh.
Elena
>
> Andrew
> 2002-10-23 Andrew Cagney <cagney@redhat.com>
>
> * gdbarch.sh (DEPRECATED_DO_REGISTERS_INFO): Rename
> DO_REGISTERS_INFO.
> gdbarch.h, gdbarch.c: Re-generate.
> * infcmd.c (default_print_registers_info): Update reference.
> * mips-tdep.c (mips_gdbarch_init): Set deprecated_do_registers_info.
> (mips_dump_tdep): Do not print DO_REGISTERS_INFO.
> * sh-tdep.c (sh_gdbarch_init): Ditto.
> * mn10300-tdep.c (mn10300_gdbarch_init): Ditto.
> * h8300-tdep.c (h8300_gdbarch_init): Ditto.
>
> Index: doc/ChangeLog
> 2002-10-23 Andrew Cagney <cagney@redhat.com>
>
> * gdbint.texinfo (Target Architecture Definition): Delete
> definition of DO_REGISTERS_INFO.
>
> Index: gdbarch.sh
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbarch.sh,v
> retrieving revision 1.165
> diff -u -r1.165 gdbarch.sh
> --- gdbarch.sh 16 Oct 2002 20:50:21 -0000 1.165
> +++ gdbarch.sh 23 Oct 2002 22:48:13 -0000
> @@ -468,7 +468,7 @@
> v:2:MAX_REGISTER_VIRTUAL_SIZE:int:max_register_virtual_size::::0:-1
> f:2:REGISTER_VIRTUAL_TYPE:struct type *:register_virtual_type:int reg_nr:reg_nr::0:0
> #
> -F:2:DO_REGISTERS_INFO:void:do_registers_info:int reg_nr, int fpregs:reg_nr, fpregs
> +F:2:DEPRECATED_DO_REGISTERS_INFO:void:deprecated_do_registers_info:int reg_nr, int fpregs:reg_nr, fpregs
> m:2:PRINT_REGISTERS_INFO:void:print_registers_info:struct ui_file *file, struct frame_info *frame, int regnum, int all:file, frame, regnum, all:::default_print_registers_info::0
> M:2:PRINT_FLOAT_INFO:void:print_float_info:struct ui_file *file, struct frame_info *frame, const char *args:file, frame, args
> M:2:PRINT_VECTOR_INFO:void:print_vector_info:struct ui_file *file, struct frame_info *frame, const char *args:file, frame, args
> Index: h8300-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/h8300-tdep.c,v
> retrieving revision 1.21
> diff -u -r1.21 h8300-tdep.c
> --- h8300-tdep.c 20 Sep 2002 14:22:44 -0000 1.21
> +++ h8300-tdep.c 23 Oct 2002 22:48:13 -0000
> @@ -1085,7 +1085,7 @@
> set_gdbarch_register_virtual_size (gdbarch, h8300_register_raw_size);
> set_gdbarch_max_register_virtual_size (gdbarch, h8300h_reg_size);
> set_gdbarch_register_virtual_type (gdbarch, h8300_register_virtual_type);
> - set_gdbarch_do_registers_info (gdbarch, h8300_do_registers_info);
> + set_gdbarch_deprecated_do_registers_info (gdbarch, h8300_do_registers_info);
> set_gdbarch_print_float_info (gdbarch, h8300_print_float_info);
>
> /*
> Index: infcmd.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/infcmd.c,v
> retrieving revision 1.57
> diff -u -r1.57 infcmd.c
> --- infcmd.c 3 Oct 2002 02:34:07 -0000 1.57
> +++ infcmd.c 23 Oct 2002 22:48:14 -0000
> @@ -1571,10 +1571,9 @@
> char *raw_buffer = alloca (MAX_REGISTER_RAW_SIZE);
> char *virtual_buffer = alloca (MAX_REGISTER_VIRTUAL_SIZE);
>
> - /* FIXME: cagney/2002-03-08: This should be deprecated. */
> - if (DO_REGISTERS_INFO_P ())
> + if (DEPRECATED_DO_REGISTERS_INFO_P ())
> {
> - DO_REGISTERS_INFO (regnum, print_all);
> + DEPRECATED_DO_REGISTERS_INFO (regnum, print_all);
> return;
> }
>
> Index: mips-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.c,v
> retrieving revision 1.130
> diff -u -r1.130 mips-tdep.c
> --- mips-tdep.c 11 Oct 2002 14:02:37 -0000 1.130
> +++ mips-tdep.c 23 Oct 2002 22:48:17 -0000
> @@ -6060,7 +6060,7 @@
> set_gdbarch_register_virtual_type (gdbarch, mips_register_virtual_type);
> set_gdbarch_register_virtual_size (gdbarch, generic_register_size);
>
> - set_gdbarch_do_registers_info (gdbarch, mips_do_registers_info);
> + set_gdbarch_deprecated_do_registers_info (gdbarch, mips_do_registers_info);
> set_gdbarch_pc_in_sigtramp (gdbarch, mips_pc_in_sigtramp);
>
> /* Hook in OS ABI-specific overrides, if they have been registered. */
> @@ -6193,9 +6193,6 @@
> fprintf_unfiltered (file,
> "mips_dump_tdep: CAUSE_REGNUM = %d\n",
> CAUSE_REGNUM);
> - fprintf_unfiltered (file,
> - "mips_dump_tdep: DO_REGISTERS_INFO # %s\n",
> - XSTRING (DO_REGISTERS_INFO));
> fprintf_unfiltered (file,
> "mips_dump_tdep: DWARF_REG_TO_REGNUM # %s\n",
> XSTRING (DWARF_REG_TO_REGNUM (REGNUM)));
> Index: mn10300-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mn10300-tdep.c,v
> retrieving revision 1.31
> diff -u -r1.31 mn10300-tdep.c
> --- mn10300-tdep.c 24 Aug 2002 00:21:35 -0000 1.31
> +++ mn10300-tdep.c 23 Oct 2002 22:48:17 -0000
> @@ -1148,7 +1148,7 @@
> set_gdbarch_register_virtual_size (gdbarch, mn10300_register_virtual_size);
> set_gdbarch_register_virtual_type (gdbarch, mn10300_register_virtual_type);
> set_gdbarch_dwarf2_reg_to_regnum (gdbarch, mn10300_dwarf2_reg_to_regnum);
> - set_gdbarch_do_registers_info (gdbarch, mn10300_do_registers_info);
> + set_gdbarch_deprecated_do_registers_info (gdbarch, mn10300_do_registers_info);
> set_gdbarch_sp_regnum (gdbarch, 8);
> set_gdbarch_pc_regnum (gdbarch, 9);
> set_gdbarch_fp_regnum (gdbarch, 31);
> Index: sh-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/sh-tdep.c,v
> retrieving revision 1.72
> diff -u -r1.72 sh-tdep.c
> --- sh-tdep.c 28 Sep 2002 16:11:29 -0000 1.72
> +++ sh-tdep.c 23 Oct 2002 22:48:19 -0000
> @@ -4289,7 +4289,7 @@
> set_gdbarch_pc_regnum (gdbarch, 16);
> set_gdbarch_register_size (gdbarch, 4);
> set_gdbarch_register_bytes (gdbarch, SH_DEFAULT_NUM_REGS * 4);
> - set_gdbarch_do_registers_info (gdbarch, sh_do_registers_info);
> + set_gdbarch_deprecated_do_registers_info (gdbarch, sh_do_registers_info);
> set_gdbarch_breakpoint_from_pc (gdbarch, sh_breakpoint_from_pc);
> set_gdbarch_frame_chain (gdbarch, sh_frame_chain);
> set_gdbarch_get_saved_register (gdbarch, generic_get_saved_register);
> @@ -4516,7 +4516,7 @@
> set_gdbarch_pseudo_register_read (gdbarch, sh64_pseudo_register_read);
> set_gdbarch_pseudo_register_write (gdbarch, sh64_pseudo_register_write);
>
> - set_gdbarch_do_registers_info (gdbarch, sh64_do_registers_info);
> + set_gdbarch_deprecated_do_registers_info (gdbarch, sh64_do_registers_info);
> set_gdbarch_frame_init_saved_regs (gdbarch, sh64_nofp_frame_init_saved_regs);
> set_gdbarch_breakpoint_from_pc (gdbarch, sh_sh64_breakpoint_from_pc);
> set_gdbarch_init_extra_frame_info (gdbarch, sh64_init_extra_frame_info);
> Index: config/pa/tm-hppa.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/config/pa/tm-hppa.h,v
> retrieving revision 1.18
> diff -u -r1.18 tm-hppa.h
> --- config/pa/tm-hppa.h 24 Aug 2002 00:21:36 -0000 1.18
> +++ config/pa/tm-hppa.h 23 Oct 2002 22:48:20 -0000
> @@ -249,10 +249,10 @@
> (buf)[sizeof(CORE_ADDR) -1] &= ~0x3; \
> } while (0)
>
> -/* Define DO_REGISTERS_INFO() to do machine-specific formatting
> +/* Define DEPRECATED_REGISTERS_INFO() to do machine-specific formatting
> of register dumps. */
>
> -#define DO_REGISTERS_INFO(_regnum, fp) pa_do_registers_info (_regnum, fp)
> +#define DEPRECATED_REGISTERS_INFO(_regnum, fp) pa_do_registers_info (_regnum, fp)
> extern void pa_do_registers_info (int, int);
>
> #if 0
> Index: doc/gdbint.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
> retrieving revision 1.106
> diff -u -r1.106 gdbint.texinfo
> --- doc/gdbint.texinfo 18 Oct 2002 18:50:43 -0000 1.106
> +++ doc/gdbint.texinfo 23 Oct 2002 22:48:24 -0000
> @@ -3218,12 +3218,6 @@
> If defined, this should evaluate to 1 if @var{addr} is in a shared
> library in which breakpoints cannot be set and so should be disabled.
>
> -@item DO_REGISTERS_INFO
> -@findex DO_REGISTERS_INFO
> -If defined, use this to print the value of a register or all registers.
> -
> -This method is deprecated.
> -
> @item PRINT_FLOAT_INFO()
> @findex PRINT_FLOAT_INFO
> If defined, then the @samp{info float} command will print information about