This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Fix an error in value_change_enclosing_type
muller@cerbere.u-strasbg.fr writes:
> At 17:05 18/10/2002 -0400, Elena Zannoni wrote:
> >Pierre Muller writes:
> > >
> > >
> > >
> > > the function value_change_enclosing_type
> > > does not set the enlclosing_type field correctly if
> > > the new_encl_type has a bigger length that the value type.
> > >
> > > Its seems quite astonishing that this has not been noticed before,
> > > but I discovered it when trying to get
> > > the fpc-abi.c code to work correctly.
> > >
> >
> >The fix seems OK. However, do you have a small testcase? It would be
> >good to add it to the testsuite.
> Sorry, but I don't have any, because I really don't even know
> if this code is ever executed for C code. It is for
> Free Pascal generated code, that is how I discovered that bug.
> But I can't add tests with Free Pascal anyhow.
>
Oh, ok.
> >Does this fix changes the results for the already existing tests?
>
> Sorry, but I never worked with the testsuite,
> so I can't answer this question.
>
Could you run make check in your gdb/testsuite directory in the build
tree? All I meant is, whether or not the test results are different
before and after your change.
thanks
Elena