This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA/testsuite: Add MIPS to gdb.asm
On Mon, Oct 21, 2002 at 12:30:53PM -0700, Michael Snyder wrote:
> Andrew Cagney wrote:
> >
> > FYI, MichaelS tends to handle these.
> >
> > Andrew
> >
> > -------------------------------------------------------------------------------
> >
> > Subject: RFA/testsuite: Add MIPS to gdb.asm
> > Date: Sat, 12 Oct 2002 15:37:26 -0400
> > From: Daniel Jacobowitz <drow@mvista.com>
> > To: gdb-patches@sources.redhat.com
> > CC: fnasser@redhat.com
> >
> > I was squashing MIPS GNU/Linux failures this morning and the 24 fails from
> > gdb.asm finally annoyed me... so I squashed them. The ChangeLog is pretty
> > explanatory; the only subtle part was a change from "selected stack frame"
> > to "(foo2|selected stack frame)". Because of the .ent information, GDB
> > knows which function the frame belongs to. The .ent information is
> > necessary to write PIC code on MIPS, and all user code is PIC.
> >
> > Is this OK?
>
> You added one unnecessary blank line at the beginning of asmsrc1.s,
> which was the only thing that necessitated some of your line-number changes
> in the expect strings. If you take that out, the rest is approved.
Ooh - thanks for noticing that, it was a leftover from the previous
version of gdbasm_declare. The diff's much prettier now. Committed,
with that change.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer