Re: 5.3 branch? Was: insight rename patch

[Keith Seitz <keiths at redhat dot com>]

On Thu, 26 Sep 2002, Andrew Cagney wrote:

> Committed to HEAD.....
> > 
> > Index: gdbtk/ChangeLog
> > 2002-09-25  Andrew Cagney  <ac131313@redhat.com>
> > 
> > 	From Grace Sainsbury <graces@redhat.com>:
> > 	* generic/gdbtk-main.c: New file.

FYI, I've committed a testsuite cleanup in 
testsuite/lib/insight-support.exp which will get it to run the "insight" 
executable instead of gdb.

Keith

ChangeLog
2002-09-26  Keith Seitz  <keiths@redhat.com>

        * lib/insight-support.exp (gdbtk_start): Figure out where
        the insight executable is based on where gdb is. Use this
        executable to start insight instead of gdb.

Patch
Index: testsuite/lib/insight-support.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/insight-support.exp,v
retrieving revision 1.5
diff -p -r1.5 insight-support.exp
*** testsuite/lib/insight-support.exp	4 Oct 2001 22:11:12 -0000	1.5
--- testsuite/lib/insight-support.exp	27 Sep 2002 14:47:14 -0000
*************** proc gdbtk_start {test} {
*** 54,60 ****
  
    gdb_stop_suppressing_tests;
  
!   verbose "Starting $GDB -nx -q --tclcommand=$test"
  
    set real_test [which $test]
    if {$real_test == 0} {
--- 54,68 ----
  
    gdb_stop_suppressing_tests;
  
!   # Need to convert ::GDB to use (-)?insight...
!   if {[regsub {gdb$} $GDB insight newGDB]} {
!     set INSIGHT $newGDB
!   } else {
!     perror "Cannot find Insight executable"
!     exit 1
!   }
! 
!   verbose "Starting $INSIGHT -nx -q --tclcommand=$test"
  
    set real_test [which $test]
    if {$real_test == 0} {
*************** proc gdbtk_start {test} {
*** 63,70 ****
    }
  
    if {![is_remote host]} {
!     if { [which $GDB] == 0 } {
!       perror "$GDB does not exist."
        exit 1
      }
    }
--- 71,78 ----
    }
  
    if {![is_remote host]} {
!     if { [which $INSIGHT] == 0 } {
!       perror "$INSIGHT does not exist."
        exit 1
      }
    }
*************** proc gdbtk_start {test} {
*** 91,99 ****
    set env(GDBTK_VERBOSE) 1
    set env(GDBTK_LOGFILE) [to_tcl_path [file join $objdir gdb.log]]
  
!   set err [catch {exec $GDB -nx -q --tclcommand=$test} res]
    if { $err } {
!     perror "Execing $GDB failed: $res"
      append res "\nERROR gdb-crash"
    }
    return $res
--- 99,107 ----
    set env(GDBTK_VERBOSE) 1
    set env(GDBTK_LOGFILE) [to_tcl_path [file join $objdir gdb.log]]
  
!   set err [catch {exec $INSIGHT -nx -q --tclcommand=$test} res]
    if { $err } {
!     perror "Execing $INSIGHT failed: $res"
      append res "\nERROR gdb-crash"
    }
    return $res