This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Minor reformatting in infrun.c


Absolutely. But unfortunately this is not the way indent formats it:

<<
          stop_bpstat =
            bpstat_stop_status
            (&stop_pc,
             sw_single_step_trap_p
             || (currently_stepping (ecs)
                 && prev_pc != stop_pc - DECR_PC_AFTER_BREAK
                 && !(step_range_end
                      && INNER_THAN (read_sp (), (step_sp - 16)))));

Why not just do:

int not_a_sw_breakpoint = ......
stop_bpstat = ..., not_a_sw_breakpoint, ...

the expression is unreasonably complex anyway :-)

enjoy,
Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]