This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] GDB/622 - clear current breakpoint in commands causes trouble
- From: Michael Snyder <msnyder at redhat dot com>
- To: Joel Brobecker <brobecker at gnat dot com>
- Cc: gdb-patches at sources dot redhat dot com, dhoward at redhat dot com
- Date: Thu, 22 Aug 2002 15:01:24 -0700
- Subject: Re: [RFA] GDB/622 - clear current breakpoint in commands causes trouble
- Organization: Red Hat, Inc.
- References: <20020731195012.GK683@gnat.com> <20020820132752.GD25997@gnat.com>
Joel Brobecker wrote:
>
> ping?
>
> > 2002-07-31 Joel Brobecker <brobecker@gnat.com>
> >
> > * cli/cli-scripts.c (copy_command_lines): New function.
> > (make_cleanup_free_command_lines): Make this function non static.
> >
> > * defs.h (copy_command_lines): Add definition.
> > (make_cleanup_free_command_lines): Add definition.
> >
> > * breakpoint.c (bpstat_do_actions): Execute a temporary copy of
> > the command-list associated to each breakpoint hit, in order to
> > avoid accessing a dangling pointer, in case one of the commands
> > in the list causes the breakpoint to be deleted.
Joel,
It looks OK to me, but I'd like to run it by Don Howard,
who has looked at this before. Don, this patch looks a lot
simpler than the one you submitted (which, I think, died on
the vine (mea culpa)). Do you think it will do the job?
Michael