This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: Change all fopen modes to binary in cli-dump.c [was Re:[RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin]


On Thu, Aug 08, 2002 at 12:57:13PM -0400, Andrew Cagney wrote:

BTW,

NickC's just pointed Corinna and I at include/fopen-{bin,same}.c. I guess GDB could just use those when it wants a binary file open.

In the light of this I had a closer look to cli/cli-dump.c and
found that there are a lot of constand "w"'s "a"'s and "r"'s
used.  So the previous patch was pretty incomplete.  The below
patch substitutes every constant fopen mode in cli/cli-dump.c
by the appropriate binary open mode define from include/fopen-bin.h.

Ok to check in?

Corinna

2002-08-09  Corinna Vinschen  <vinschen@redhat.com>

	* cli/cli-dump.c: Change fopen modes to use binary open modes
	as defined in include/fopen-bin.h throughout.

Yes, thanks! (I think I'll try to figure out a way of ARIing this so that we don't forget again :-)

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]