This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Thu, Aug 01, 2002 at 04:48:05PM -0400, Andrew Cagney wrote: > >I'm not sure if this is intended or not, but objfiles.h relies on > >symfile.h for the definition of certain structures. However, objfiles > >does not #include symfile. So my attempt to include objfiles without > >prior including symfile caused a compilation error. > > What exactly? A mindless grep suggests opaque references but not a hard > dependency. Adding an opaque ``struct sym_fns;'' to avoid an include is ok. Here are the fields in struct objfile that cause the compilation error: /* Vectors of all partial symbols read in from file. The actual data is stored in the psymbol_obstack. */ struct psymbol_allocation_list global_psymbols; struct psymbol_allocation_list static_psymbols; So the full definition is need for this file to compile. >2002-08-01 Joel Brobecker <brobecker@gnat.com> > > * objfiles.h: Add missing #include "symfile.h" > > * Makefile.in (objfiles_h): Add dependency on symfile.h and > dependents. > > >+ #include "symfile.h" > > Suggest a comment mentioning what was needed. The attached patch contains the suggested comment. > PS: I've this memory of, on true64 or hpux, there being a tangled mess > of includes that stopped the above from being added. That, however, is > a true64/hppa problem and is likely fixed by multi-arching. Just to be on the safe side, I have regression tested this patch on HP/UX 11.00, and Tru64 5.1A. No problem. -- Joel
Attachment:
objfiles.h.diff
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |