Re: [PATCH] Cross target core debugging: host=i386, Target=PPC

[Kevin Buettner <kevinb at redhat dot com>]

On Jul 30, 11:32am, Daniel Jacobowitz wrote:

> +#define ELF_NGREG       48      /* includes nip, msr, lr, etc. */
> +#define ELF_NFPREG      33      /* includes fpscr */
> +#define ELF_NVRREG      33      /* includes vscr */

I noticed that the above are never actually referenced anywhere.  Can
we dispense with these defines?  Or are there some hard coded
constants lurking somewhere that should actually be defined in terms
of one or more of the above?

Which reminds me...  I think the recent trend in gdb has been to use
enums for constants rather than #define where possible.

Aside from the above concerns, your patch looks okay to me.

Kevin