This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] DW_AT_calling_convention support
[I can't approve this but] that sounds good to me. I'm not arguing
that there shouldn't be a get_main_symbol, only that there should be
an opaque check for the main symbol which doesn't require calling both
that and get_main_name ().
On Wed, Jul 10, 2002 at 10:32:07AM -0400, Petr Sorfa wrote:
> Hi Daniel,
>
> Great, however I do suggest get_main_symbol() for greater flexibility.
> I've moved the code to deal with DW_AT_calling_convention into
> dwarf2read.c's new_symbol() function (as opposed to detecting it while
> reading a type). Let me know what you think and I'll have a patch ready
> soon.
>
> Petr
> > On Wed, Jul 10, 2002 at 09:53:35AM -0400, Petr Sorfa wrote:
> > > Hi Daniel,
> > >
> > > > I'd rather save a pointer the symbol for the main function, or
> > > > something along those lines - do you think that's workable?
> > > Sounds good. Note that I'm making the assumption that the symbol is
> > > associated with a type that is only associated with that symbol (iff).
> > >
> > > I think it should be API driven, like set_main_symbol () and
> > > get_main_symbol () and situated in symtab.c alonside set_main_name() and
> > > main_name().
> >
> > Yep, that's about what I had in mind. How about:
> >
> > set_main_name ()
> > set_main_symbol ()
> > is_main_symbol ()
> > - if a main symbol is set, check if it is the same symbol
> > - otherwise, check if it has the same name as passed to
> > set_main_name
> >
> > (with appropriate care for when we change object files.... to one
> > without a DWARF-2 main symbol, even...)
> >
> > --
> > Daniel Jacobowitz Carnegie Mellon University
> > MontaVista Software Debian GNU/Linux Developer
>
>
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer