This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] more m68k multi-arch


On Jun 24,  1:10pm, Grace Sainsbury wrote:

> +#if !GDB_MULTI_ARCH
>  #define STORE_STRUCT_RETURN(ADDR, SP) \
>    { write_register (A1_REGNUM, (ADDR)); }
>  
> @@ -221,11 +228,13 @@
>  	         (TYPE_LENGTH(TYPE) >= 4 ? 0 : 4 - TYPE_LENGTH(TYPE)),	\
>  	  TYPE_LENGTH(TYPE))
>  #endif
> +#endif //multi-arch

I've noticed the addition of a number of ``#if !GDB_MULTI_ARCH''
statements in your patch.  Presumably, these are temporary until
you finish the job, right?  (I'm wondering if it's necessary to
keep them around at all.)

Also...  be careful with // comments.  While these do work with gcc,
they don't work with all C compilers, so use /* ...  */ instead.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]