This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Update D10V generic_dummy calls
- From: Michael Snyder <msnyder at redhat dot com>
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Cc: Michael Snyder <msnyder at cygnus dot com>, gdb-patches at sources dot redhat dot com, ezannoni at redhat dot com
- Date: Thu, 23 May 2002 17:03:35 -0700
- Subject: Re: [PATCH] Update D10V generic_dummy calls
- Organization: Red Hat, Inc.
- References: <200205231538.g4NFcam31809@reddwarf.sfbay.redhat.com> <3CED74F0.5060908@cygnus.com>
Andrew Cagney wrote:
>
> > 2002-05-22 Michael Snyder <msnyder@redhat.com>
> >
> > * d10v-tdep.c: Change a few macros to enums for ease of debugging.
> > (d10v_frame_chain_valid): Add PC_IN_CALL_DUMMY clause.
> > (d10v_frame_saved_pc): Add PC_IN_CALL_DUMMY clause.
> > (d10v_frame_chain): Bail immediately if PC_IN_CALL_DUMMY.
> > Don't bail if return_pc is PC_IN_CALL_DUMMY.
> > Add a temp variable to save a call (and a memory read).
> > (d10v_init_extra_frame_info): Get fi->pc from callee's return_pc
> > if possible (so that PC_IN_CALL_DUMMY will work).
> >
>
> Michael,
>
> This patch:
>
> > *************** d10v_gdbarch_init (struct gdbarch_info i
> > *** 1486,1492 ****
> > set_gdbarch_register_byte (gdbarch, d10v_register_byte);
> > set_gdbarch_register_raw_size (gdbarch, d10v_register_raw_size);
> > set_gdbarch_max_register_raw_size (gdbarch, 8);
> > ! set_gdbarch_register_virtual_size (gdbarch, generic_register_size);
> > set_gdbarch_max_register_virtual_size (gdbarch, 8);
> > set_gdbarch_register_virtual_type (gdbarch, d10v_register_virtual_type);
> >
> > --- 1525,1531 ----
> > set_gdbarch_register_byte (gdbarch, d10v_register_byte);
> > set_gdbarch_register_raw_size (gdbarch, d10v_register_raw_size);
> > set_gdbarch_max_register_raw_size (gdbarch, 8);
> > ! set_gdbarch_register_virtual_size (gdbarch, generic_register_virtual_size);
> > set_gdbarch_max_register_virtual_size (gdbarch, 8);
> > set_gdbarch_register_virtual_type (gdbarch, d10v_register_virtual_type);
> >
>
> Wasn't mentioned in the change log and breaks d10v builds :-(
Eh? I don't remember doing that...
Oh! My source tree isn't up to date!
Sorry about that -- please withdraw this patch and I'll re-submit.
Good thing I hadn't gotten around to checking it in yet...