This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] IA64 fix for breakpoints on L in MLX instruction bundles


Hi,

Committed.

Petr
> Hi Kevin,
> 
> My apologies, I'll fix the indentation.
> 
> Petr
> > On May 9,  1:00pm, Petr Sorfa wrote:
> >
> > > Patch for handling breakpoints on the L instruction type in an MLX
> > > bundle.
> > >
> > >
> > > 2002-05-09  Petr Sorfa (petrs@caldera.com)
> > >
> > >         * ia64-tdep.c: Handle breakpoints on L instruction type
> > >         in MLX instruction bundle by moving the breakpoint to
> > >         the third slot (X instruction type) as L holds only data.
> >
> > Approved, but I'd like you to fix a minor indentation issue prior
> > to committing it though...
> >
> > > +   if (slotnum == 1 && template_encoding_table[template][1] == L)
> > > +   {
> > > +     slotnum = 2;
> > > +   }
> >
> > This should look like this instead:
> >
> > > +   if (slotnum == 1 && template_encoding_table[template][1] == L)
> > > +     {
> > > +       slotnum = 2;
> > > +     }
> >
> > Or just:
> >
> > > +   if (slotnum == 1 && template_encoding_table[template][1] == L)
> > > +     slotnum = 2;
> >
> > Thanks,
> >
> > Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]