This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[RFA] Disable "remote_rdp_can_run"
- From: Michael Snyder <msnyder at cygnus dot com>
- To: gdb-patches at sources dot redhat dot com
- Cc: rearnsha at arm dot com
- Date: Thu, 2 May 2002 16:19:08 -0700
- Subject: [RFA] Disable "remote_rdp_can_run"
Happened across this. It's not right.
With this in place, if you have not attached to your rdp target
(ie. by saying "target rdp"), but you instead just say "run",
gdb will attempt to use the rdp target, which has not at this
point been opened or initialized. This is not the right way
to make a remote target accept the "run" command.
2002-05-02 Michael Snyder <msnyder@redhat.com>
* remote-rdp.c (remote_rdp_can_run): Return false. This is
not a good work-around for making a remote target accept 'run'.
Index: remote-rdp.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-rdp.c,v
retrieving revision 1.24
diff -p -r1.24 remote-rdp.c
*** remote-rdp.c 13 Feb 2002 16:24:59 -0000 1.24
--- remote-rdp.c 2 May 2002 23:25:40 -0000
*************** remote_rdp_create_inferior (char *exec_f
*** 1367,1373 ****
static int
remote_rdp_can_run (void)
{
! return 1;
}
/* Attach doesn't need to do anything */
--- 1367,1378 ----
static int
remote_rdp_can_run (void)
{
! /* You certainly can't run unles you've attached to your target board.
! If you want to save some sort of global state that tells you if
! you've attached, then maybe you can accept the run command
! (but I still don't think that would be right -- remote targets
! don't accept the run command (nor do they accept "attach")). */
! return 0;
}
/* Attach doesn't need to do anything */