This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa:sparc] Remove write_fp() from sparc-tdep.c
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Andrew Cagney <ac131313 at cygnus dot com>, gdb-patches at sources dot redhat dot com
- Date: Fri, 5 Apr 2002 17:02:39 -0700
- Subject: Re: [rfa:sparc] Remove write_fp() from sparc-tdep.c
- References: <3CAE1F58.4070601@cygnus.com>
On Apr 5, 5:04pm, Andrew Cagney wrote:
> if (strcmp (target_shortname, "sim") != 0)
> {
> - write_fp (old_sp);
> -
> + if (gdbarch_tdep (current_gdbarch)->intreg_size == 8)
How about
if (GDB_TARGET_IS_SPARC64)
instead? (That matches the existing convention in the rest of the
file better.)
Aside from that, I think your change is fine. Something to consider
though is whether the entire
if (strcmp (target_shortname, "sim") != 0)
{
...
}
could simply go away. I.e, let the "sim" case just use the non-sim
code.
Kevin