This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: x86-64-tdep.h cleanup
Kevin Buettner wrote:
> On Mar 5, 4:56pm, Michal Ludvig wrote:
>>* x86-64-tdep.h (sys/reg.h, x86_64_regmap): Moved to x86-64-linux-nat.c
>>(x86_64_linux_frame_saved_pc,
>>x86_64_linux_saved_pc_after_call): Moved to x86-64-tdep.c
>>* x86-64-linux-nat.c (sys/reg.h, x86_64_regmap): Moved here
>>from x86-64-tdep.h
>>* x86-64-tdep.c (x86_64_linux_frame_saved_pc,
>>x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h
> I'm not the maintainer of the files in questions, but your changes
> look okay to me.
There is no maintainer of this port right now. Can I understand your
message as an approval?
> should be written like this instead:
>
> * x86-64-tdep.c (x86_64_linux_frame_saved_pc)
> (x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h.
>
> (I've been told that emacs is happier if ChangeLog entries are
> formatted this way.)
Thanks for notice, I reformatted them.
Michal Ludvig
--
* SuSE CR, s.r.o * mludvig@suse.cz
* +420 2 9654 5373 * http://www.suse.cz