This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rfc] Eliminate TARGET_BYTE_ORDER_SELECTABLE


> Nope! I'm about to delete TARGET_BYTE_ORDER_DEFAULT.
>> 
>> There is this really nasty bit of code in arch-utils.c that roots around 
>> the internals of BFD and uses that to determine the initial architecture 
>> and byte-order.  Doing this ensures that GDB's behavour is better 
>> aligned with that of BINUTILS.
>> See arch-utils.c:initialize_current_architecture().
>> 
>> If GDB initializes its self to the wrong byte-order then there is likely 
>> a bug in BFD.
> 
> 
> Oh, I see.  I -think- this will work correctly for my targets; I'll
> check after you do it.


BTW, the MIPS has been using this since:

Wed Jun  7 18:27:51 2000  Andrew Cagney  <cagney@b1.cygnus.com>

        * configure.in (DEFAULT_BFD_ARCH, DEFAULT_BFD_VEC): Use config.bfd
        to determine the default architecture / target.
        * acconfig (DEFAULT_BFD_ARCH, DEFAULT_BFD_VEC): Add.
        * configure, config.in: Regenerate.
        
        * arch-utils.c (set_endian): Better separate multi-arch and non-
        multi-arch cases.
        (set_endian_from_file): Call internal_error when multi-arch.
        (initialize_current_architecture): Rewrite logic selecting a byte
        order.  Use DEFAULT_BFD_ARCH DEFAULT_BFD_VEC.
        (version.h): Include.

        * config/mips/tm-mips.h, config/mips/tm-bigmips64.h,
        config/mips/tm-bigmips.h: Delete definition of
        TARGET_BYTE_ORDER_DEFAULT.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]