[RFA/RFC 3] Remove hardware break and watchpoints at program exit.

[Pierre Muller <muller at cerbere dot u-strasbg dot fr>]

After the  previous discussion about  the 
hardware watch and breakpoint removal 
about the debuggee exited. I slightly modifed my patch
by adding a test to avoid calling ptrace
in i386-linux-nat.c, i386bsd-nat.c and x86-64-linux-nat.c
i386_linux_dr_set, i386bsd_dr_set and x86_64_linux_dr_set functions
if taget_has_execution is 0.


I have a little doubt about the default value of the
HARDWARE_REGISTER_RESET macro.
What should be used as a no-op default ?



2002-01-09  Pierre Muller <muller@ics.u-strasbg.fr>

          * breakpoint.c (REMOVE_HARDWARE_BREAKPOINT_AT_EXIT): 
          Define to 0 if not defined.
          (REMOVE_HARDWARE_WATCHPOINT_AT_EXIT): 
          Define to 0 if not defined.
          (HARDWARE_REGISTER_RESET): Default to no-op.
          (breakpoint_init_inferior): Use REMOVE_HARDWARE_BREAKPOINT_AT_EXIT
          and REMOVE_HARDWARE_WATCHPOINT_AT_EXIT to conditionally
          remove hardware break and watchpoints at exit.
          Call HARDWARE_REGISTER_RESET macro if defined at exit.

          * config/i386/nm-i386.h: Define HARDWARE_REGISTER_RESET
          macro to call i386_cleanup_dregs().
          Set REMOVE_HARDWARE_BREAKPOINT_AT_EXIT to 1.
          Set REMOVE_HARDWARE_WATCHPOINT_AT_EXIT to 1.

          * go32-nat.c (go32_mourn_inferior): Remove call to i386_cleanup_dregs
          as this is done in breakpoint_init_inferior().
	* i386-linux-nat.c (i386_linux_dr_set): Don't call ptrace if target_has_execution is zero.
	* i386bsd-nat.c (i386bsd_dr_set): Likewise.
	* x86-64-linux-nat.c (x86_64_linux_dr_set): Likewise.

Attachment: dregs.diffs
Description: Text document

Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99