Re: bogus xfails in default.exp

[Fernando Nasser <fnasser at redhat dot com>]

You are right.  If they want a different text (and different test) 
they have to do it in their sources, not in the FSF repository.

Please check it in.

Regards,
Fernando

law@redhat.com wrote:
> 
> The only thing I can think of is this stuff came in from HP; my guess
> is these failed on HP's sources because HP probably twiddled the
> version and warranty information.
> 
> These xfails are horribly bogus IMHO.
> 
>         * gdb.base/default.exp: Remove bogus hppa*-hp-hpux* xfails.
> 
> Index: default.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
> retrieving revision 1.3
> diff -c -3 -p -r1.3 default.exp
> *** default.exp 2001/05/23 19:04:13     1.3
> --- default.exp 2001/12/20 22:35:11
> *************** gdb_test "info types" "All defined types
> *** 345,351 ****
>   #test info variables
>   gdb_test "info variables" "All defined variables:" "info variables"
>   #test info warranty
> - setup_xfail "hppa*-hp-hpux*"
>   gdb_test "info warranty" "NO WARRANTY.*\[\r\n\]+  *11.  *BECAUSE THE PROGRAM
> IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY.*\[\r\n\]+FOR THE PROGRAM, TO
> THE EXTENT PERMITTED BY APPLICABLE LAW.  EXCEPT WHEN.*\[\r\n\]+OTHERWISE
> STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES.*\[\r\n\]+PROVIDE
> THE PROGRAM \"AS IS\" WITHOUT WARRANTY OF ANY KIND, EITHER
> EXPRESSED.*\[\r\n\]+OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
> WARRANTIES OF.*\[\r\n\]+MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
> THE ENTIRE RISK AS.*\[\r\n\]+TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS
> WITH YOU.  SHOULD THE.*\[\r\n\]+PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST
> OF ALL NECESSARY SERVICING,.*\[\r\n\]+REPAIR OR CORRECTION..*\[\r\n\]+  *12.
> *IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN
> WRITING.*\[\r\n\]+WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY
> AND/OR.*\[\r\n\]+REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU
> FOR DAMAGES,.*\[\r\n\]+INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR
> CONSEQUENTIAL DAMAGES ARISING.*\[\r\n\]+OUT OF THE USE OR INABILITY TO USE THE
> PROGRAM .INCLUDING BUT NOT LIMITED.*\[\r\n\]+TO LOSS OF DATA OR DATA BEING
> RENDERED INACCURATE OR LOSSES SUSTAINED BY.*\[\r\n\]+YOU OR THIRD PARTIES OR A
> FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER.*\[\r\n\]+PROGRAMS., EVEN IF
> SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE.*\[\r\n\]+POSSIBILITY OF
> SUCH DAMAGES.*" "info warranty"
>   #test info watchpoints
>   gdb_test "info watchpoints" "No breakpoints or watchpoints." "info
> watchpoints"
> --- 345,350 ----
> *************** gdb_test "show values" "" "show values"
> *** 657,663 ****
>   #test show verbose
>   gdb_test "show verbose" "Verbose printing of informational messages is
> o.*|Verbosity is off.*" "show verbose"
>   #test show version
> - setup_xfail "hppa*-hp-hpux*"
>   gdb_test "show version" "GNU gdb \[0-9\.\]*.*\[\r\n\]+Copyright \[0-9\]*
> Free Software Foundation, Inc.*\[\r\n\]+GDB is free software, covered by the
> GNU General Public License, and you are.*\[\r\n\]+welcome to change it and/or
> distribute copies of it under certain conditions.*\[\r\n\]+Type \"show
> copying\" to see the conditions.*\[\r\n\]+There is absolutely no warranty for
> GDB.  Type \"show warranty\" for details.*\[\r\n\]+This GDB was configured as
> .*|GDB is free software and you are welcome to distribute copies of
> it.*\[\r\n\]+ under certain conditions; type \"show copying\" to see the
> conditions..*\[\r\n\]+There is absolutely no warranty for GDB; type \"show
> warranty\" for details..*\[\r\n\]+GDB.*Copyright \[0-9\]* Free Software
> Foundation, Inc.*" "show version"
>   #test show width
>   gdb_test "show width" "Number of characters gdb thinks are in a line is.*"
> "show width"
> --- 656,661 ----

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9