This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Fix regexp problem with "operator* etc.
- From: Michael Snyder <msnyder at cygnus dot com>
- To: Elena Zannoni <ezannoni at cygnus dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 05 Dec 2001 12:11:00 -0800
- Subject: Re: [RFA] Fix regexp problem with "operator* etc.
- Organization: Red Hat, Inc.
- References: <200111020929.DAA09585@duracef.shout.net> <3C0BCFF9.3C476F2@cygnus.com> <15374.10460.202277.477676@krustylu.cygnus.com>
Elena Zannoni wrote:
>
> Michael Snyder writes:
> >
> > I committed this change, without Michael Chastain's worthy suggestion
> > regarding the size of the alloca. Will submit that separately.
> >
> > Michael Elizabeth Chastain wrote:
> > >
> > > cplusfuncs.exp:
> > > In my maintainer area.
> > > Approved unconditionally.
> > > No matter what gdb does, the test script should do the right thing.
> > >
> > > alloca change:
> > > Outside my maintainer area.
> > > Recommended for rework.
> > >
> > > I think the size is long enough, but the proof of correctness is
> > > too delicate. There is no space explicitly allocated for the final
> > > null, so the alloca is correct only because it occurs in a context
> > > where at least one character is being deleted. This also relies on
> > > some character-class tests being the same in this function and
> > > in operator_chars. How about something stupidly correct:
> > >
> > > alloca (8 + fix + strlen(opname) + 1)
>
> Ah, OK.
>
> > >
> > > operator_chars change:
> > > Outside my maintainer area.
> > > Proofread and tested, works for me.
> > > Recommended for approval.
>
> Whoops, I missed this one. Sorry, I'll go and look at it. Did you
> commit it already?
Yep, I guess I mistook silence for assent. Sorry if I overstepped.
I'll back it out if it doesn't look OK to you.