This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] correct XMM register positions for win32.
- From: Christopher Faylor <cgf at redhat dot com>
- To: gdb-patches <gdb-patches at sources dot redhat dot com>
- Date: Fri, 30 Nov 2001 12:03:24 -0500
- Subject: Re: [RFA] correct XMM register positions for win32.
- References: <4.2.0.58.20011130154628.00aca598@ics.u-strasbg.fr>
Please check this in, Pierre.
Also, please use 'diff -up' or 'diff -cp' for your future patches.
cgf
On Fri, Nov 30, 2001 at 03:50:14PM +0100, Pierre Muller wrote:
> Thanks to Momchil Velikov,
>Windows seems indeed to use FXSAVE
>assemlber instruction to fill the ExtendedRegisters
>array.
>
> The same instruction with the same layout seems to be used
>by the Pentium clones (at least for AMD).
>
>Thus the offset changed below are now
>tested and conform to the FXSAVE
>instruction.
>
>
>2001-11-30 Pierre Muller <muller@ics.u-strasbg.fr>
> * win32-nat.c (mappings): Correct position of XMM registers,
> based on FXSAVE instruction structure.
>
>Index: win32-nat.c
>===================================================================
>RCS file: /cvs/src/src/gdb/win32-nat.c,v
>retrieving revision 1.40
>diff -r1.40 win32-nat.c
>182,191c182,191
>< context_offset (ExtendedRegisters[0*16]),
>< context_offset (ExtendedRegisters[1*16]),
>< context_offset (ExtendedRegisters[2*16]),
>< context_offset (ExtendedRegisters[3*16]),
>< context_offset (ExtendedRegisters[4*16]),
>< context_offset (ExtendedRegisters[5*16]),
>< context_offset (ExtendedRegisters[6*16]),
>< context_offset (ExtendedRegisters[7*16]),
>< /* MXCSR untested */
>< context_offset (ExtendedRegisters[8*16])
>---
> > context_offset (ExtendedRegisters[10*16]),
> > context_offset (ExtendedRegisters[11*16]),
> > context_offset (ExtendedRegisters[12*16]),
> > context_offset (ExtendedRegisters[13*16]),
> > context_offset (ExtendedRegisters[14*16]),
> > context_offset (ExtendedRegisters[15*16]),
> > context_offset (ExtendedRegisters[16*16]),
> > context_offset (ExtendedRegisters[17*16]),
> > /* MXCSR */
> > context_offset (ExtendedRegisters[24])