This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[RFA] infptrace.c: use regcache_collect
- From: Elena Zannoni <ezannoni at cygnus dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Mon, 19 Nov 2001 14:30:51 -0500
- Subject: [RFA] infptrace.c: use regcache_collect
Is this ok?
Thanks
Elena
2001-11-19 Elena Zannoni <ezannoni@redhat.com>
* infptrace.c (fetch_register): Dynamically allocate buffer for
register.
(store_register): Use regcache_collect, instead of accessing the
register buffer directly.
Index: infptrace.c
===================================================================
RCS file: /cvs/uberbaum/gdb/infptrace.c,v
retrieving revision 1.18
diff -u -p -c -r1.18 infptrace.c
cvs server: conflicting specifications of output style
*** infptrace.c 2001/10/21 14:53:46 1.18
--- infptrace.c 2001/11/19 19:23:08
*************** fetch_register (int regno)
*** 359,365 ****
char mess[128]; /* For messages */
register int i;
unsigned int offset; /* Offset of registers within the u area. */
! char buf[MAX_REGISTER_RAW_SIZE];
int tid;
if (CANNOT_FETCH_REGISTER (regno))
--- 359,365 ----
char mess[128]; /* For messages */
register int i;
unsigned int offset; /* Offset of registers within the u area. */
! char *buf = alloca (MAX_REGISTER_RAW_SIZE);
int tid;
if (CANNOT_FETCH_REGISTER (regno))
*************** store_register (int regno)
*** 424,429 ****
--- 424,430 ----
register int i;
unsigned int offset; /* Offset of registers within the u area. */
int tid;
+ char *buf = alloca (MAX_REGISTER_RAW_SIZE);
if (CANNOT_STORE_REGISTER (regno))
{
*************** store_register (int regno)
*** 437,447 ****
offset = U_REGS_OFFSET;
regaddr = register_addr (regno, offset);
for (i = 0; i < REGISTER_RAW_SIZE (regno); i += sizeof (PTRACE_XFER_TYPE))
{
errno = 0;
ptrace (PT_WRITE_U, tid, (PTRACE_ARG3_TYPE) regaddr,
! *(PTRACE_XFER_TYPE *) & registers[REGISTER_BYTE (regno) + i]);
regaddr += sizeof (PTRACE_XFER_TYPE);
if (errno != 0)
{
--- 438,453 ----
offset = U_REGS_OFFSET;
regaddr = register_addr (regno, offset);
+
+ /* Put the contents of regno into a local buffer */
+ regcache_collect (regno, buf);
+
+ /* Store the local buffer into the inferior a chunk at the time. */
for (i = 0; i < REGISTER_RAW_SIZE (regno); i += sizeof (PTRACE_XFER_TYPE))
{
errno = 0;
ptrace (PT_WRITE_U, tid, (PTRACE_ARG3_TYPE) regaddr,
! *(PTRACE_XFER_TYPE *) (buf + i));
regaddr += sizeof (PTRACE_XFER_TYPE);
if (errno != 0)
{