This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] New tests for 'const' and 'volatile' expressions


Michael Snyder wrote:
> 
> Fernando Nasser wrote:
> >
> > Michael Snyder wrote:
> > >
> > > This is a test that I forgot to submit back in September,
> > > after submitting the changes to the expression parser that
> > > permitted more complex expressions involving const and volatile.
> >
> > Nice, new tests are good!
> >
> > > I've tested the test on several native and embedded targets.
> > >
> >
> > Do they pass?
> 
> Oh, yes -- no failures, when tested on the main branch.
> I have not tested the 5.1 branch.  If it fails, there would
> be two choices:
> 
>   * merge the parser patch onto the branch
>   * omit this test from the branch.
> >


As this is a new feature, it would not make much sense have it 
where the feature was not yet added, right?

So I would say it goes where you previous patch goes, and only there.

I guess you can check it in to the trunk now.


-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]