This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[rfa/i386] disconnect ``set dissassembly-flavour'' from ``set architecture''
- To: gdb-patches at sources dot redhat dot com
- Subject: [rfa/i386] disconnect ``set dissassembly-flavour'' from ``set architecture''
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Wed, 07 Nov 2001 21:10:14 -0500
Hello,
Per discussion on GDB@ mailing list. The attached disconnects the commands:
set disssassembly-flavour
and set architecture
ok to commit?
Andrew
Wed Nov 7 20:45:32 2001 Andrew Cagney <cagney@redhat.com>
* i386-tdep.c (set_disassembly_flavor): Delete function.
(set_disassembly_flavor_sfunc): Delete function.
Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.42
diff -p -r1.42 i386-tdep.c
*** i386-tdep.c 2001/11/04 13:51:48 1.42
--- i386-tdep.c 2001/11/08 02:00:02
*************** static const char *valid_flavors[] =
*** 188,200 ****
};
static const char *disassembly_flavor = att_flavor;
- /* This is used to keep the bfd arch_info in sync with the disassembly
- flavor. */
- static void set_disassembly_flavor_sfunc (char *, int,
- struct cmd_list_element *);
- static void set_disassembly_flavor (void);
-
-
/* Stdio style buffering was used to minimize calls to ptrace, but
this buffering did not take into account that the code section
being accessed may not be an even number of buffers long (even if
--- 188,193 ----
*************** gdb_print_insn_i386 (bfd_vma memaddr, di
*** 1200,1225 ****
internal_error (__FILE__, __LINE__, "failed internal consistency check");
}
- /* If the disassembly mode is intel, we have to also switch the bfd
- mach_type. This function is run in the set disassembly_flavor
- command, and does that. */
-
- static void
- set_disassembly_flavor_sfunc (char *args, int from_tty,
- struct cmd_list_element *c)
- {
- set_disassembly_flavor ();
- }
-
- static void
- set_disassembly_flavor (void)
- {
- if (disassembly_flavor == att_flavor)
- set_architecture_from_arch_mach (bfd_arch_i386, bfd_mach_i386_i386);
- else if (disassembly_flavor == intel_flavor)
- set_architecture_from_arch_mach (bfd_arch_i386,
- bfd_mach_i386_i386_intel_syntax);
- }
/* Provide a prototype to silence -Wmissing-prototypes. */
--- 1193,1198 ----
*************** _initialize_i386_tdep (void)
*** 1255,1265 ****
Set the disassembly flavor, the valid values are \"att\" and \"intel\", \
and the default value is \"att\".",
&setlist);
- new_cmd->function.sfunc = set_disassembly_flavor_sfunc;
add_show_from_set (new_cmd, &showlist);
}
-
- /* Finally, initialize the disassembly flavor to the default given
- in the disassembly_flavor variable. */
- set_disassembly_flavor ();
}
--- 1228,1233 ----