Re: [RFA] deleting breakpoints inside of 'commands' (again)

[Michael Snyder <msnyder at cygnus dot com>]

Don Howard wrote:
> 
> On Mon, 5 Nov 2001, Michael Snyder wrote:
> 
> > Fernando Nasser wrote:
> > >
> > > Don Howard wrote:
> > > >
> > > > This implementation makes a copy of commands list that contain 'delete'
> > > > or 'clear' commands.  It also attempts to clean up when an error in
> > > > encountered.  Comments?
> >
> > Don, I hesitate to say anything, because I know this has been beaten
> > to death already, but does this method account for the possibility that
> > the list might contain a call to another user command which in turn
> > calls "delete" or "clear"?
> >
> 
> Good point - I should have caught that.  In place of the strncmp()
> calls in the previous patch, I've added a call to this:
> 
> /* Walk a list of struct command_lines and try to determine if any
>    command deletes breakpoints */
> 
> int bpstat_actions_delete_breakpoints (struct command_line * cmd)
> {
>   for (; cmd; cmd = cmd->next)
>     {
>       int i;
> 
>       if (strncmp (cmd->line, "dele", 4) == 0 ||
>           strncmp (cmd->line, "clea", 4) == 0)
>         return 1;
> 
>       for (i=0; i<cmd->body_count; i++)
>         if (bpstat_actions_delete_breakpoints (cmd->body_list[i]))
>           return 1;
>     }
> 
>   return 0;
> }
> 
> Comments?

Much better.  I'm ready to say let's give it a go.   ;-)
Michael