This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [rfa] gdbserver 2/n - signals


> On Thu, Jul 19, 2001 at 05:48:57PM -0400, Andrew Cagney wrote:
> 
>> > 
>> > I was going to use that, except for a few small problems:
>> > - wasted space, a couple of functions and the large name table.
>> > I'm not really bothered by this one.
>> > - warning() and internal_error() calls, which gdbserver doesn't
>> > provide.
>> > 
>> > Perhaps re-using it despite those minor hurdles would be wiser.  I'll
>> > tweak the patch.
> 
>> 
>> 
>> The compiler/linker should be able to eliminate the unused code (can 
>> GCC?).  Adding warning() and internal_error() wouldn't hurt.
> 
> 
> Only if you're using -ffunction-sections.  Otherwise you're stuck with
> the whole object file.  At least, I think so...


If someone is that despearate about the size of their executable, the'll 
be using -ffunction-sections regardless :-)


> This better?


looks ok with me.  You may want to see of J.T. has any comments about 
gdbserver and definitly Eli about the documentation.

	Andrew

> 2001-07-19  Daniel Jacobowitz  <drow@mvista.com>
> 
> * gdbserver/server.c (main): Call target_signal_to_host_p
> 	and target_signal_to_host on signals received from the remote.
> 	* gdbserver/remote-utils.c (prepare_resume_reply): Call
> 	target_signal_from_host on signals sent to the remote.
> 	* gdbserver/Makefile.in: Add signals.o, built from
> 	the parent directory.
> 
> 2001-07-19  Daniel Jacobowitz  <drow@mvista.com>
> 
> * gdb.texinfo (Protocol): Mention that signal numbers
> 	are defined by the target_signal enum.





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]