This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[rfa] gdbserver 1/n - PBUFSIZ
- To: gdb-patches at sources dot redhat dot com
- Subject: [rfa] gdbserver 1/n - PBUFSIZ
- From: Daniel Jacobowitz <dmj+ at andrew dot cmu dot edu>
- Date: Thu, 19 Jul 2001 11:36:06 -0700
The things I've been discussing w.r.t. qRegisters and such need to be done,
but they also need to be done properly, and I certainly won't have time to
do enough testing before 5.1. It's possible to make gdbserver work in
roughly the right way, such that it will be friendly to the new work when
that's ready, without all the intrusive changes. I'm going to try to do
that in time for 5.1.
Here's the first bit. PBUFSIZ is used as an array initializer, but defined
in terms of REGISTER_BYTES - which might not be a constant, and which I'd
rather hide anyway. Later on, the design I'm hashing out for gdbserver's
register cache will make it very easy to find the maximum value of
REGISTER_BYTES, and we can make PBUFSIZ flexible again; for now, I made it
"big enough".
OK to commit?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
2001-07-19 Daniel Jacobowitz <drow@mvista.com>
* gdbserver/server.h: Make PBUFSIZ a constant.
Index: server.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/server.h,v
retrieving revision 1.3
diff -u -r1.3 server.h
--- server.h 2001/03/06 08:21:44 1.3
+++ server.h 2001/07/19 18:28:05
@@ -81,6 +81,9 @@
/* Buffer sizes for transferring memory, registers, etc. Round up PBUFSIZ to
hold all the registers, at least. */
+/* FIXME - REGISTER_BYTES is not known at this time.
#define PBUFSIZ ((REGISTER_BYTES > MAXBUFBYTES (2000)) \
? (REGISTER_BYTES * 2 + 32) \
: 2000)
+*/
+#define PBUFSIZ 4096