This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Avoid compiler warnings in mips-tdep.c
- To: Eli Zaretskii <eliz at is dot elta dot co dot il>
- Subject: Re: [RFA] Avoid compiler warnings in mips-tdep.c
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Fri, 18 May 2001 11:51:06 +0800
- Cc: gdb-patches at sources dot redhat dot com
- References: <Pine.SUN.3.91.1010517175343.14151F-100000@is>
> Please consider the following patches to mips-tdep.c, to avoid compiler
> warnings and fix one typo in a comment.
>
>
> 2001-05-17 Eli Zaretskii <eliz@is.elta.co.il>
>
> * mips-tdep.c (show_mipsfpu_command): Remove unused variable msg.
> (mips_set_processor_type_command): Remove unused variable j.
> (mips_breakpoint_from_pc): Declare breakpoint instruction
> sequences as unsigned char, to avoid compiler warnings.
Yes, fixes like this one are pretty obvious.
It is only when people introduce things like casts to gag warnings that
I'll start to wonder.
Andrew
PS: Would -Wunused be a good next candidate for -Werror?