This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] Avoid compiler warnings in mips-tdep.c


> Please consider the following patches to mips-tdep.c, to avoid compiler 
> warnings and fix one typo in a comment.
> 
> 
> 2001-05-17  Eli Zaretskii  <eliz@is.elta.co.il>
> 
> * mips-tdep.c (show_mipsfpu_command): Remove unused variable msg.
> 	(mips_set_processor_type_command): Remove unused variable j.
> 	(mips_breakpoint_from_pc): Declare breakpoint instruction
> 	sequences as unsigned char, to avoid compiler warnings.


Yes, fixes like this one are pretty obvious.
It is only when people introduce things like casts to gag warnings that 
I'll start to wonder.

	Andrew

PS: Would -Wunused be a good next candidate for -Werror?



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]