This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH, RFC]: Change order of setting i386 debug registers
- To: kettenis at wins dot uva dot nl
- Subject: Re: [PATCH, RFC]: Change order of setting i386 debug registers
- From: Eli Zaretskii <eliz at delorie dot com>
- Date: Sat, 31 Mar 2001 11:23:22 -0500 (EST)
- CC: gdb-patches at sources dot redhat dot com
- References: <200103311556.f2VFu2O00222@delius.kettenis.local>
- Reply-to: Eli Zaretskii <eliz at is dot elta dot co dot il>
> Date: Sat, 31 Mar 2001 17:56:02 +0200
> From: Mark Kettenis <kettenis@wins.uva.nl>
>
> FreeBSD/i386 does some strict checking on the debug registers before
> setting them. This conflicts a bit with the order in which the code
> in i386-nat.c tries to set the registers. The attached patch fixes
> these problems by changing the order in which we modify the
> registers. Instead of enabling an address register before storing the
> proper address in it, after the patch, we will first store the address
> and then enable the address register. This seems more correct to me.
You are right; it was my mistake not to do it that way in the first
place.
> Any objections to checking this in?
Please do.