This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] testsuite/gdb.c++/ref-types.exp: use runto


Michael Elizabeth Chastain <chastain@cygnus.com> writes:

> Actually, I'm suggesting two things:
> 
> (1) In the gdb test suite, print FAIL when gdb gives a wrong answer.
> 
> (2) In gdb, figure out a cover set for the cases that fail, and
>     don't execute those cases.
>     
> "virtual functions altogether" would certainly cover all the buggy cases,
> but it's too broad.
> 
> Perhaps "virtual functions in for classes where the complete type has
> a virtual base"?
This is still a lot of cases, because of mixin use.

I think I can come up with a better heuristic.
How bout i do a minimal symbol lookup on the address we think the
virtual function is at, and make sure it's the start of some real
function (and if you really want to go a bit further, i'll make sure
it's a function in the class, or it's base classes)

It's going to be exteremely rare that we come up with an address that
happens to match this heuristic, but isn't correct (because we'll
end up not at the start address of a function 99% of the time if we
are wrong).


--Dan
> 
> Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]