This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH RFA] gdb.base/signals.exp: explicitly set count = 0
- To: Orjan Friberg <orjan dot friberg at axis dot com>
- Subject: Re: [PATCH RFA] gdb.base/signals.exp: explicitly set count = 0
- From: Fernando Nasser <fnasser at redhat dot com>
- Date: Thu, 15 Mar 2001 09:29:28 -0500
- CC: gdb-patches at sources dot redhat dot com
- Organization: Red Hat Canada
- References: <3AB0C976.53755DF7@axis.com>
Orjan Friberg wrote:
>
> gdb.base/signals.exp runs the main function in signals.c twice.
> signal.c contains a static variable count which is initialized to 0.
> The second time the main function is run, the test case relies on count
> being 0, which depends on how runto_main is implemented for the target.
> My target does a simple "jump *main", which obviously doesn't
> re-initialize count to 0. This patch sets count to 0 explicitly.
>
> Ok to commit?
>
Yes.
The way it is implemented now also depends on the effect of rerunning a
program in static variables. For some remote targets this can also
imply that count is not zero if one does not "load" again (in case
someone did not specify "do_reload_on_run" for the target -- although
this would be a mistake IMO).
Fernando
> 2001-03-15 Orjan Friberg <orjanf@axis.com>
>
> * gdb.base/signals.exp: Set count to 0 explicitly.
>
> Index: signals.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/signals.exp,v
> retrieving revision 1.2
> diff -c -3 -p -r1.2 signals.exp
> *** signals.exp 2001/03/06 08:21:51 1.2
> --- signals.exp 2001/03/15 13:35:40
> *************** gdb_expect {
> *** 370,375 ****
> --- 370,378 ----
> }
>
> if [runto_main] then {
> + # Since count is a static variable outside main, runto_main
> + # is no guarantee that count will be 0 at this point.
> + gdb_test "set variable count = 0" ""
> gdb_test "break handler if 0" "Breakpoint \[0-9\]+ .*"
> gdb_test "set \$handler_breakpoint_number = \$bpnum" ""
>
>
> --
> Orjan Friberg E-mail: orjan.friberg@axis.com
> Axis Communications AB Phone: +46 46 272 17 68
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9