This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH]: misc header file cleanup.
- To: Michael Elizabeth Chastain <chastain at cygnus dot com>
- Subject: Re: [PATCH]: misc header file cleanup.
- From: jtc at redback dot com (J.T. Conklin)
- Date: 01 Mar 2001 13:43:26 -0800
- Cc: gdb-patches at sourceware dot cygnus dot com
- References: <200103012059.MAA12281@bosch.cygnus.com>
- Reply-To: jtc at redback dot com
>>>>> "Michael" == Michael Elizabeth Chastain <chastain@cygnus.com> writes:
Michael> Proofread, no problems found.
Many thanks.
Michael> MIN_OF_TYPE is never used. MAX_OF_TYPE is used only in
Michael> m2-exp.y in some code that is #if 0'd out.
Correct. But had that code in m2-exp.y been enabled, the lack of
parens in MAX_OF_TYPE would have surprising results. In any case,
there is no harm to fix the macros now in case someone decides to
use them later.
I suspect there will be quite a few nits that linting will be turn up.
Some will be of this nature, where it's a "obviously correct" fix. I
suspect quite a few will highlight poor divisions of interface and
implementation (for example, declarations of functions in multiple
header files, etc.). And other things I choose to simple suppress
(fortunately, the lint I'm using has very finegrained control over
error message generation).
--jtc
--
J.T. Conklin
RedBack Networks