This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] regcache.c (register_fetched) + related changes


David Taylor wrote:

> I propose that we:
> 
> . add register_fetched

David,

The functionality of register_fetched() overlaps with
set_register_cached() and supply_register().  Rather than add a
redundant method, could an existing interface be used or the current
interfaces rationalized slightly?

Keep in mind that the long term goal is to tighten regcache's interface
signficantly.  That is, eliminate register_valid[], registers[] and
possibly even set_register_cached() replacing them with a small set of
functions such as:
	supply_register()
	supply_unavailable_register()
If you are thinking of proposing further changes then you may want to
keep that in mind.

With regard to regcache.h, yes the two clash.  It both moves code around
and changes the set_register_cached() interface.  If anything regcache.h
makes life easier because it is finally clear what the regcache
interfaces really are.

	Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]