This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] fix child_xfer_memory in hppah-nat.c
- To: Michael Elizabeth Chastain <chastain at cygnus dot com>
- Subject: Re: [RFA] fix child_xfer_memory in hppah-nat.c
- From: Michael Snyder <msnyder at cygnus dot com>
- Date: Mon, 05 Feb 2001 12:18:38 -0800
- CC: gdb-patches at sourceware dot cygnus dot com
- Organization: Red Hat
- References: <200102040619.WAA29062@bosch.cygnus.com>
Michael Elizabeth Chastain wrote:
>
> This patch fixes hppah-nat.c:xfer_child_memory to declare the new
> 'struct mem_attrib *' argument.
>
> This patch is needed to build sourceware gdb on hpux 10.20.
>
> Jeff Law is the maintainer of "hpux, hp pa native", but Jeff is on
> vacation right now. So I appeal to one of the blanket write maintainers
> for approval.
<heavenly choir>
Good Pilgrim -- Your Appeal Has Been Granted!
</heavenly choir>
>
> I tested this patch by building on an hpux 10.20 machine.
>
> This patch does not make hpux gdb actually work. When I run a child
> process, gdb goes catatonic. This is the same behavior that sourceware
> gdb had in the 2001-01-22 version (a day before the interface change to
> child_xfer_memory). By using an older gdb to debug both the 2001-01-22
> gdb and today's gdb with my patch applied, I saw that neither of them
> got as far as child_xfer_memory.
>
> OK to commit?
>
> Michael Elizabeth Chastain
> <chastain@redhat.com>
> "love without fear"
>
> ===
>
> 2001-02-03 Michael Chastain <chastain@redhat.com>
>
> * hppah-nat.c (xfer_child_memory): Add parameter 'struct mem_attrib *'
> to conform with interface change.
>
> ====
>
> Index: gdb/hppah-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/hppah-nat.c,v
> retrieving revision 1.6
> diff -c -3 -p -r1.6 hppah-nat.c
> *** gdb/hppah-nat.c 2000/12/15 01:01:47 1.6
> --- gdb/hppah-nat.c 2001/02/03 20:32:50
> *************** fetch_register (int regno)
> *** 266,271 ****
> --- 266,272 ----
>
> int
> child_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write,
> + struct mem_attrib *mem,
> struct target_ops *target)
> {
> register int i;