Re: [RFA]: Apropos patch

[Daniel Berlin <dan at cgsoftware dot com>]

On Thu, 23 Mar 2000, Stan Shebs wrote:

> "Daniel Berlin+list.gdb-patches" wrote:
> > 
> > Okay, new patch attached that does as you ask.
> > I added more testcases as well.
> 
> Just four more nits, and then I'll shut up.  First, put the void
> return type of the functions on lines by themselves - we like
> to find function names in column 1.  

It is that way in my version, i must have fixed that right after
sending the patch.

>Second, the functions should be static if possible, looks like the helper
>function can be at least.
Out of curiosity, why?
I come from a multithreaded planet, where the idea is to try to make
things *not* static if possible :).

> Third, please add prototypes at the top of the file. 

Sure.

> Finally,
> the help string should probably be rephrased a bit - use the
> word "matching" at least, and ideally say "regular expression".
> Do help rbreak for an example.

howzabout "Search for all commands matching REGEXP"?
> 
> > i now use "apropos <the handle regex>", "apropos apropos", and
> > "apropos handle a signal", which tests all the various things that
> > could go wrong (excluding screwing up your regex, which will properly
> > give you the error from the regex engine), like making sure multiple
> > word aproposes work, etc.
> 
> That's excellent - now the testsuite will help protect your new command
> from bitrot...

> 
> Stan
>