This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: A patch for gnu-regex


   Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm
   Precedence: bulk
   List-Unsubscribe: <mailto:gdb-patches-unsubscribe-kettenis=wins.uva.nl@sourceware.cygnus.com>
   List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.cygnus.com>
   List-Archive: <http://sourceware.cygnus.com/ml/gdb-patches/>
   List-Post: <mailto:gdb-patches@sourceware.cygnus.com>
   List-Help: <mailto:gdb-patches-help@sourceware.cygnus.com>, <http://sourceware.cygnus.com/ml/#faqs>
   Sender: gdb-patches-owner@sourceware.cygnus.com
   Date: Tue, 7 Mar 2000 16:21:27 -0800
   From: "H . J . Lu" <hjl@lucon.org>
   Cc: Stan Shebs <shebs@apple.com>, gdb-patches@sourceware.cygnus.com,
      GDB <gdb@sourceware.cygnus.com>
   Content-Type: text/plain; charset=us-ascii

   On Tue, Mar 07, 2000 at 04:18:23PM -0800, J.T. Conklin wrote:
   > >>>>> "hjl" == H J Lu <hjl@valinux.com> writes:
   > 
   > hjl> 2000-03-07  H.J. Lu  <hjl@gnu.org>
   > hjl>
   > hjl> 	* gdb-regex.h: New. Include <regex.h> for glibc 2 and include
   > hjl> 	"gnu-regex.h" otherwise.
   > 
   > If we follow the naming convention we have been using, gdb-regex.h

   There are gdb-events.c   gdb-events.h   gdb-events.sh  gdb-regex.h
   gdb-stabs.h.

That are files that contain real code!  We use gdb_string.h,
gdb_stat.h, etc. for headers that are nothing but wrappers.

   > should be gdb_regex.h.

   Either way is fine with me. All I want is regex in glibc 2 :-). Any
   objections?

Is this really important?  From an engineering standpoint introducing
a dependency on glibc may not be the right thing.  I've seen a quite a
few problems related to regex.h that were caused by getting out of
sync with glibc.  I'd prefer not to add this to GDB 5.0.

You might also want to look at /usr/include/gnu-versions.h for an
alternative approach of makeing sure that the duplicate code is
elided, although the necessary preprocessor magic seems to be missing
from regex.c.  Should not be hard to add though.

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]