Comments welcome (Was: Re: RFC: Patch to arm-tdep.c -- Register flavors)

[Fernando Nasser <fnasser at cygnus dot com>]

On an aside from the thread, I would like to thanks Scott for his
comments.  We are in need of those as much as we are for patches (or
almost ;-).

With the volume of things going on, it is easy to make mistakes or
overlook a small detail.  Also, we get an indication of what are the
preferences (unfortunately the list does not have a percentage of users
high enough to be of statistical significance, but it is an indication
at least).

Thanks,
Fernando

Scott Bambrough wrote:
> 
> Fernando,
> 
> I have a couple of minor nits:
> 
> Could you submit a unified diff instead of the context diff.  It would be easier
> to read.  Personally I prefer diff -up.
> 
> I don't see the need for the code that is ifdef'ed out in _initialize_arm_tdep.
> You should resolve this before committing the patch.
> 
> Is the othernames command really necessary?  Perhaps we should take this
> opportunity to remove it.  I won't miss it.  It's just another command to
> document.
> 
> I think the default register names should be set by the port.  Most Linux users
> don't use the APCS/ATPCS register names.  I don't find them intuitive at all
> myself.
> 
> Scott
> 
> --
> Scott Bambrough - Software Engineer
> REBEL.COM    http://www.rebel.com
> NetWinder    http://www.netwinder.org

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@cygnus.com
2323 Yonge Street, Suite #300           Tel:  416-482-2661 ext. 311
Toronto, Ontario   M4P 2C9              Fax:  416-482-6299