This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: New port: CRIS architecture


FYI,

I can't find an assignment in place?

Several more generic comments.

tm-cris.h:
	I'm trying to figure out why it is needed.
	The obvious problem is SOFTWARE_SINGLESTEP_P.
	I'll fix that.

	Beyond that one, what else is needed?  I'd
	like to see a second pure multi-arch target
	in GDB so will help where needed.

cris-tdep.c:
	It is preferable to have enums and
	two line functions rather than macros.
	They both make the long term job of
	maintenance far easier.

	Other files have put __initialize*
	and xxx_arch_init() at the end.  I'd
	just suggest moving them.

	Other than that, absolutly nothing
	has jumped up and even the above
	are not problems.

cool!
	Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]