This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH RFC] Protoize m32r-stub.c, m88k-nat.c, m88k-tdep.c


>>>>> "Kevin" == Kevin Buettner <kevinb@cygnus.com> writes:
>> Should we consider not protoizing the *-stub.c files?  While these are
>> distributed with GDB, they are code that is going to be hacked to bits
>> as they are integrated into a remote target.  While user is probably
>> using gcc, it may be reasonable to be as conservative we can when it 
>> comes to these files...

Kevin> You're right.  I think that Andrew (and perhaps others) warned
Kevin> me about this too.

Kevin> I hereby withdraw the m32r-stub.c portion of the patch.

Kevin> Also, I will need to revert many of the changes that occurred in my
Kevin> changes of 2000-07-29.  Specifically, I'll need to revert the changes
Kevin> that were made to the following files:

Kevin>     i386-stub.c
Kevin>     m32r-stub.c
Kevin>     m68k-stub.c
Kevin>     sh-stub.c
Kevin>     sparc-stub.c
Kevin>     sparcl-stub.c
Kevin>     sparclet-stub.c

And I should have cought this and commented then.  Sorry 'bout that.  
I've been overwhelmed as of late.

Kevin> I'll post a separate RFC for the reversion changes and wait a few days
Kevin> for comments as usual.

Don't jump the gun.  As Stan says, there are reasons that we might
want to protoize the files.  Lets make sure the pros and cons of stub
protoization are understood, and then make a decision whether to keep
the work you already have completed or to revert it.

I'm pretty ambivilent about it myself.  In my experience, beyond toy
programs, stubs get hacked quite extensively to integrate them into
the target system.  Removing protototypes would be the least of the
user's worries.

        --jtc

-- 
J.T. Conklin
RedBack Networks

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]