This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch to build gdb-5.0 with readline-4.1


Andrew Cagney writes:
 > Elena Zannoni wrote:
 > 
 > > I don't understand this claim. Readline uses savestring.  Nothing
 > > has changed between rl 4.0 and 4.1 (pretty much) w.r.t. savestring.
 > > Except for the following change, which is the one that causes the
 > > conflicts:
 > 
 > Sorry, yes, I miss read the note:
 > 
 > d.  The library no longer exports a function named `savestring' --
 > backwards
 >     compatibility be damned.
 > 
 > they lied :-)
 > 

Yes.

 > 
 > > In readline.h:
 > > 
 > >  #if !defined (savestring)
 > > -extern char *savestring ();    /* XXX backwards compatibility */
 > > +extern char *savestring __P((char *)); /* XXX backwards compatibility */
 > >  #endif
 > > 
 > > So another alternative could be to remove the parameter from the
 > > above, i.e. put it back to what it was. But I still prefer Michael's
 > > suggestion, while waiting for Andrew to switch over to a libiberty
 > > equivalent.
 > 
 > There are ~50 savestring() references in readline while there are ~170
 > in GDB.
 > Given there is no guarentee of when (if ever) I'll get around to 
 > replacing savestring() you're free to choose the easiest solution -
 > gdb/savestring() -> gdb/gdb_savestring() or readline/savestring() ->
 > readline/rl_savestring().  (or both).
 > 
 > 	Andrew

OK.

Elena

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]