This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: Patch to build gdb-5.0 with readline-4.1
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Subject: Re: Patch to build gdb-5.0 with readline-4.1
- From: Elena Zannoni <ezannoni at cygnus dot com>
- Date: Thu, 6 Jul 2000 10:07:30 -0400 (EDT)
- Cc: Elena Zannoni <ezannoni at cygnus dot com>, msnyder at cygnus dot com, Andrew Gaylard <andrew dot gaylard at za dot didata dot com>, Eli Zaretskii <eliz at is dot elta dot co dot il>, andrew dot gaylard at bsw dot co dot za, gdb-patches at sourceware dot cygnus dot com, "Mark E." <snowball3 at bigfoot dot com>
- References: <39316D76.EAB1DAD8@bsw.co.za><200005290738.DAA06104@indy.delorie.com><3932236B.60A9BF69@za.didata.com><395B86CE.3499@cygnus.com><3932FA80.C24DB9F6@cygnus.com><14691.46229.916206.472987@kwikemart.cygnus.com><39645209.E25E14FA@cygnus.com>
Andrew Cagney writes:
> Elena Zannoni wrote:
>
> > I don't understand this claim. Readline uses savestring. Nothing
> > has changed between rl 4.0 and 4.1 (pretty much) w.r.t. savestring.
> > Except for the following change, which is the one that causes the
> > conflicts:
>
> Sorry, yes, I miss read the note:
>
> d. The library no longer exports a function named `savestring' --
> backwards
> compatibility be damned.
>
> they lied :-)
>
Yes.
>
> > In readline.h:
> >
> > #if !defined (savestring)
> > -extern char *savestring (); /* XXX backwards compatibility */
> > +extern char *savestring __P((char *)); /* XXX backwards compatibility */
> > #endif
> >
> > So another alternative could be to remove the parameter from the
> > above, i.e. put it back to what it was. But I still prefer Michael's
> > suggestion, while waiting for Andrew to switch over to a libiberty
> > equivalent.
>
> There are ~50 savestring() references in readline while there are ~170
> in GDB.
> Given there is no guarentee of when (if ever) I'll get around to
> replacing savestring() you're free to choose the easiest solution -
> gdb/savestring() -> gdb/gdb_savestring() or readline/savestring() ->
> readline/rl_savestring(). (or both).
>
> Andrew
OK.
Elena