This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] Set SER_HARDWIRE using autoconf


Eli Zaretskii wrote:
> 
> > Date: Mon, 12 Jun 2000 16:14:17 +1000
> > From: Andrew Cagney <ac131313@cygnus.com>
> >
> > I've checked in the attached.  By default a target will be built with
> > ser-tcp.o.  go32*-*-* is currently the only exception.
> 
> Andrew,
> 
> I didn't have time to actually test this change, but I think this is
> wrong: the DJGPP port uses "i386-pc-msdosdjgpp" as the value of $host.
> The value if ${gdb_host} is set to "go32", but I don't think you are
> referencing that variable in configure.in (reproduced below), are you?
> 
> I think to get this right, you need to allow both go32*-*-* and
> *-*-*djgpp in ${host}.

Up, yes. Does:

  case ${host} in
    *go32* ) SER_HARDWIRE=ser-go32.o ;;
    *djgpp* ) SER_HARDWIRE= ;;
  esac

look safer?

	Andrew


> > Index: configure.in
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/configure.in,v
> > retrieving revision 1.36
> > diff -p -r1.36 configure.in
> > *** configure.in      2000/06/11 01:39:08     1.36
> > --- configure.in      2000/06/12 06:04:04
> > *************** AC_CACHE_CHECK([for cygwin], gdb_cv_os_c
> > *** 626,631 ****
> > --- 626,640 ----
> >   lose
> >   #endif],[gdb_cv_os_cygwin=yes],[gdb_cv_os_cygwin=no])])
> >
> > +
> > + dnl Figure out which of the many generic ser-*.c files the _host_ supports.
> > + SER_HARDWIRE="ser-unix.o ser-pipe.o ser-tcp.o"
> > + case ${host} in
> > +   go32*-*-* ) SER_HARDWIRE=ser-go32.o ;;
> > + esac
> > + AC_SUBST(SER_HARDWIRE)
> > +
> > +
> >   dnl Figure out which term library to use.
> >   if test x$gdb_host = xgo32; then
> >     TERM_LIB=

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]