This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [RFA] Revised doc/Makefile.in patch
- To: cgf at cygnus dot com
- Subject: Re: [RFA] Revised doc/Makefile.in patch
- From: Eli Zaretskii <eliz at delorie dot com>
- Date: Mon, 3 Jul 2000 02:08:04 -0400 (EDT)
- CC: ac131313 at cygnus dot com, gdb-patches at sourceware dot cygnus dot com
- References: <200006231835.OAA07083@fwr.landmark.com> <200006250818.EAA07995@indy.delorie.com> <20000630010635.A14862@cygnus.com> <200006300846.EAA14373@indy.delorie.com> <20000630101845.A5618@cygnus.com> <395DAF5C.602EC73F@cygnus.com> <20000701122140.B16915@cygnus.com> <20000701235639.A20125@cygnus.com>
- Reply-to: Eli Zaretskii <eliz at is dot elta dot co dot il>
> Date: Sat, 1 Jul 2000 23:56:39 -0400
> From: Chris Faylor <cgf@cygnus.com>
>
> Actually that isn't completely true. This doesn't address Eli's concern
> about making the target of an $(INSTALL_DATA) a directory. I've never
> seen a system where this was an issue but...
I'm not aware of such an `install', either. Even install-sh supports
a directory without a file name as the destination.
The only reason I can think of for using a file name as the
destination is to rename the file on the fly. This can happen if GDB
is installed under a different name, by using the program_transform_name
feature. Currently, gdb/doc/Makefile.in doesn't support this, but
that's probably a bug, since gdb/Makefile.in does.
One possibility of solving this would be to add some shell magic to
the rule commands, to look for the files both in the build and the
source directory, instead of relying on VPATH.
However, if this is not an issue, at least in the current version, I
think your patch is okay. I will wait for a few more days (from the
traffic, it looks like many people are on the road ;-), and if no one
objects, I'll commit it.