This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] patch to solve libiberty strsignal changes (plus a minor cross-compilation fix)


Chris Faylor wrote:
> 
> Following Andrew's suggestions, I submit the following for approval.
> 
> This patch adds checks for strsignal in string.h and strings.h, moves the
> strsignal declaration from defs.h into gdb_string.h and adds a
> NEED_DECLARATION_STRSIGNAL to config.in .
> 
> This patch also includes what I hope is a no-brainer fix to find the
> correct versions of windres and ranlib (aka i686-pc-cygwin-windres and
> i686-pc-cygwin-ranlib) when cross compiling.
> 
> cgf
> 
> Thu Jun  1 22:11:19 2000  Christopher Faylor <cgf@cygnus.com>
> 
>         * configure.in: Check for declaration of strsignal in string{,s}.h.
>         Detect correct versions of ranlib and windres when cross-compiling.
>         * configure: Regenerate.
>         * config.in: Define NEED_DECLARATION_STRSIGNAL if strsignal is not
>         declared in system header file.
>         * defs.h: Move strsignal declaration into gdb_string.h.
>         * gdb_string.h: Declare strsignal here if if isn't declared anywhere
>         else.

Chris,

I'm fairly sure that GDB simply shouldn't be calling strsignal(). 
lowcore.c should use the target signal to string function while the
others are going to be made obsolete.

	Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]