Re: RFA rs6000-nat.c rc used out of scope

[Kevin Buettner <kevinb at cygnus dot com>]

On Apr 25, 11:41am, Philippe De Muyter wrote:

> Building gdb on aix4.1.5 fails with :
> gdb/rs6000-nat.c: In function `xcoff_relocate_symtab':
> gdb/rs6000-nat.c:675: `rc' undeclared (first use this function)
> gdb/rs6000-nat.c:675: (Each undeclared identifier is reported only once
> gdb/rs6000-nat.c:675: for each function it appears in.)
> 
> Here is a fix (using diff -b, to hide indent fixes)
> 
> OK to commit ? (and do we really need an approval for such sort of things,
> or would a FYI be enough ?)

Your patch is fine, and I would normally approve it.  However, I see
that the last person in this function (I won't name names) did not
apply the patch that he said he would.  (I will bug him about it
privately.)  Anyway, his proposed patch (which somehow didn't get
applied) would fix the problem with rc being out of scope as well
eliminate the use of alloca() from this function.

I'll leave it to Andrew to address your question regarding approval. 
(I'm curious about the answer myself.)

Kevin