Re: [RFA] Don't talk about ptrace when there's none

[Eli Zaretskii <eliz at delorie dot com>]

> Sender: msnyder@cygnus.com
> Date: Wed, 12 Apr 2000 10:38:54 -0700
> 
> Eli Zaretskii wrote:
> > 
> > On Wed, 12 Apr 2000, Michael Snyder wrote:
> > 
> > > Eli Zaretskii wrote:
> > >
> > > > Okay, then how about the following patch?  Good enough to commit?
> > >
> > > OK, great.
> > 
> > I'm not sure if I need to wait for someone else to approve this patch.
> > infrun.c doesn't seem to appear in MAINTAINERS.  Please advise.
> 
> Well, we definitely need to assign a maintainer for that module.
> It's way too delicate to have unapproved code checked into it.
> 
> However, I'll take responsibility for approving this patch, 
> since (a) I've worked extensively with infrun, and (b)
> it's breakpoint-related.

Thanks.

I've committed this patch (trunk and branch).

> 
> 				Michael
> 
> > Also, is it okay to check this in for the branch as well?
> > 
> > >
> > > Michael
> > >
> > > > 2000-04-11  Eli Zaretskii  <eliz@is.elta.co.il>
> > > >
> > > >         * infrun.c (proceed, normal_stop): Change the error message about
> > > >         failure to insert breakpoints/watchpoints so that it makes sense
> > > >         even if ptrace is not used or no other processes can be active.
> > > >
> > > > --- gdb/infrun.c~1      Sat Apr  1 19:41:12 2000
> > > > +++ gdb/infrun.c        Tue Apr 11 19:37:02 2000
> > > > @@ -1044,9 +1044,11 @@ proceed (CORE_ADDR addr, enum target_sig
> > > >        int temp = insert_breakpoints ();
> > > >        if (temp)
> > > >         {
> > > > -         print_sys_errmsg ("ptrace", temp);
> > > > +         print_sys_errmsg ("insert_breakpoints", temp);
> > > >           error ("Cannot insert breakpoints.\n\
> > > > -The same program may be running in another process.");
> > > > +The same program may be running in another process,\n\
> > > > +or you may have requested too many hardware\n\
> > > > +breakpoints and/or watchpoints.\n");
> > > >         }
> > > >
> > > >        breakpoints_inserted = 1;
> > > > @@ -3384,9 +3386,11 @@ normal_stop (void)
> > > >    if (breakpoints_failed)
> > > >      {
> > > >        target_terminal_ours_for_output ();
> > > > -      print_sys_errmsg ("ptrace", breakpoints_failed);
> > > > +      print_sys_errmsg ("While inserting breakpoints", breakpoints_failed);
> > > >        printf_filtered ("Stopped; cannot insert breakpoints.\n\
> > > > -The same program may be running in another process.\n");
> > > > +The same program may be running in another process,\n\
> > > > +or you may have requested too many hardware breakpoints\n\
> > > > +and/or watchpoints.\n");
> > > >      }
> > > >
> > > >    if (target_has_execution && breakpoints_inserted)
> > >
>