Re: Patches from gdb-guile (probably obsoleted by libGDB)

[Andrew Cagney <ac131313 at cygnus dot com>]

Martin Baulig wrote:
> 
> Hello,
> 
> here are some gdb patches from my guile interface of gdb - some of them
> are probably obsoleted by libGDB. However, feel free to include them in
> gdb if you want to.
> 
> Maybe some of the added annotations and hooks are also useful despite of
> libGDB.

FYI, I can't find an assignment for any changes you make to GDB.  Has
this been done?

With regard to your patch, the there isn't anything really wrong with
it.  Just several things that will make it easier to drop in:

- Don't bother with K&R'ing the code, just use ISO-C for new
code/parameters (even when the surounding code is still K&R :-).  It
make look untidy but it is still better in the long run.

- the patch added parameters to the otherwize unused error_hook() - I
believe that Fernando has some proposed changes/cleanups to the error()
interface brewing.  They likely iteract with that patch.

- I'm actually puzzled by the code:
> @@ -3316,8 +3325,12 @@
>       char *args;
>       int from_tty;
>  {
> -  if (!quit_confirm ())
> -    error ("Not confirmed.");
> +  if (! quit_confirm ())
> +    {
> +      if (! quit_confirm_hook)
> +       error ("Not confirmed.");
> +      return;
> +    }
>    quit_force (args, from_tty);
>  }
Are you just gaging the printing of the error message.

	enjoy,
		Andrew