[binutils-gdb] Provide get_shell declaration in procfs.c

Rainer Orth ro@sourceware.org
Mon Oct 29 09:31:00 GMT 2018


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=30a7953dbfe3659c7bdc5b9b4c96f46903cb0254

commit 30a7953dbfe3659c7bdc5b9b4c96f46903cb0254
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Mon Oct 29 10:28:40 2018 +0100

    Provide get_shell declaration in procfs.c
    
    The Solaris build is currently broken:
    
    /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c: In member function ‘virtual void procfs_target::create_inferior(const char*, const string&, char**, int)’:
    /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3038:28: error: ‘get_shell’ was not declared in this scope
       const char *shell_file = get_shell ();
                                ^~~~~~~~~
    /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3038:28: note: suggested alternative: ‘getusershell’
       const char *shell_file = get_shell ();
                                ^~~~~~~~~
                                getusershell
    
    The following patch fixes this.  Tested on amd64-pc-solaris2.11.
    
    
    2018-10-29  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
    
    	* procfs.c: Include common/pathstuff.h.

Diff:
---
 gdb/ChangeLog | 12 ++++++++----
 gdb/procfs.c  |  1 +
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2d89f83..1cba619 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,10 +1,14 @@
+2018-10-29  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
+
+	* procfs.c: Include common/pathstuff.h.
+
 2018-10-29   John Darrington <john@darrington.wattle.id.au>
 
 	* configure.ac: New test HAVE_AF_LOCAL
-	* common/netstuff.c (parse_connection_spec) [prefixes]: Only compile "unix:"
-	if HAVE_AF_LOCAL is true.
-	* configure: regenerate.
-	* config.in: regenerate.
+	* common/netstuff.c (parse_connection_spec) [prefixes]: Only
+	compile "unix:" if HAVE_AF_LOCAL is true.
+	* configure: Regenerate.
+	* config.in: Regenerate.
 
 2018-10-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 
diff --git a/gdb/procfs.c b/gdb/procfs.c
index ca381a7..0d8f9df 100644
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -47,6 +47,7 @@
 #include "procfs.h"
 #include "observable.h"
 #include "common/scoped_fd.h"
+#include "common/pathstuff.h"
 
 /* This module provides the interface between GDB and the
    /proc file system, which is used on many versions of Unix



More information about the Gdb-cvs mailing list